Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: add test that / performs true division, not floor division #10359

Merged
merged 3 commits into from
Oct 31, 2024
Merged

test: add test that / performs true division, not floor division #10359

merged 3 commits into from
Oct 31, 2024

Conversation

NickCrews
Copy link
Contributor

I can file an issue to track the actual flink fix for this if you want.

@github-actions github-actions bot added the tests Issues or PRs related to tests label Oct 23, 2024
cpcloud
cpcloud requested changes Oct 24, 2024
View reviewed changes
Copy link
Member

@cpcloud cpcloud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like a test-only PR here isn't going to do much beyond add an epsilon amount of time to overall test runs.

I'll poke at fixing this.

@cpcloud cpcloud added the flink Issues or PRs related to Flink label Oct 24, 2024
@cpcloud cpcloud added this to the 10.0 milestone Oct 24, 2024
@github-actions github-actions bot added the sql Backends that generate SQL label Oct 24, 2024
@NickCrews NickCrews mentioned this pull request Oct 24, 2024
Merged
@NickCrews NickCrews force-pushed the int-division branch 2 times, most recently from 974e8e0 to 31393a5 Compare October 29, 2024 20:16
@cpcloud cpcloud merged commit 75ecf03 into ibis-project:main Oct 31, 2024
77 checks passed
@NickCrews
Copy link
Contributor Author

Thanks @cpcloud! Nice job tag teaming this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cpcloud cpcloud cpcloud approved these changes

Assignees
No one assigned
Labels
flink Issues or PRs related to Flink sql Backends that generate SQL tests Issues or PRs related to tests
Projects
None yet
Milestone
10.0
Development

Successfully merging this pull request may close these issues.
2 participants
@NickCrews @cpcloud